send notifications for setting changes

ocamllabs · Dec 25, 2023 · 3862af9 · 3862af9
1 parent 8792868
commit 3862af9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src-bindings/vscode_languageclient/vscode_languageclient.ml b/src-bindings/vscode_languageclient/vscode_languageclient.ml
@@ -97,9 +97,12 @@ module OcamllspSettings = struct
 
     val extendedHover : t -> OcamllspSettingEnable.t or_undefined [@@js.get]
 
+    val syntaxDocumentation : t -> OcamllspSettingEnable.t or_undefined [@@js.get]
+
     val create :
          ?codelens:OcamllspSettingEnable.t
       -> ?extendedHover:OcamllspSettingEnable.t
+      -> ?syntaxDocumentation:OcamllspSettingEnable.t
       -> unit
       -> t
     [@@js.builder]]

diff --git a/src-bindings/vscode_languageclient/vscode_languageclient.mli b/src-bindings/vscode_languageclient/vscode_languageclient.mli
@@ -78,9 +78,12 @@ module OcamllspSettings : sig
 
   val extendedHover : t -> OcamllspSettingEnable.t option
 
+  val syntaxDocumentation : t -> OcamllspSettingEnable.t option
+
   val create :
        ?codelens:OcamllspSettingEnable.t
     -> ?extendedHover:OcamllspSettingEnable.t
+    -> ?syntaxDocumentation:OcamllspSettingEnable.t
     -> unit
     -> t
 end

diff --git a/src/vscode_ocaml_platform.ml b/src/vscode_ocaml_platform.ml
@@ -38,8 +38,14 @@ let notify_configuration_changes instance =
             ~f:(fun enable ->
               LanguageClient.OcamllspSettingEnable.create ~enable ())
         in
+        let syntaxDocumentation =
+          Option.map
+            Settings.(get server_syntaxDocumentation_setting)
+            ~f:(fun enable ->
+              LanguageClient.OcamllspSettingEnable.create ~enable ())
+        in
         let settings =
-          LanguageClient.OcamllspSettings.create ?codelens ?extendedHover ()
+          LanguageClient.OcamllspSettings.create ?codelens ?extendedHover ?syntaxDocumentation ()
         in
         let payload =
           let settings =