-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor packages and separate internal
and pkg
#129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i types and auxiliary types
…nd keep universal packages in pkg/ folder
…eManager's folder in internal/ instead of keeping them in pkg/task
…kID type. This causes mismatches if store string taskId and load with taskID taskId
powerfooI
changed the title
Refactor packages and separate
Refactor packages and separate Dec 1, 2023
internal/
and pkg/
internal
and pkg
chris-sun-star
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
api/v1alpha1
toapi/types
likeBackupVolumeSpec
.pkg/task
likeOperationContext
.controller
,resource
,telemetry
andconst
folder in previouspkg/
to a new folderinternal/
.resource
folder, the PR separate every resource manager into single folder, in which names of their tasks and task flows are included. This change increases locality of code of every resource manager and makepkg/task
a quite independent package that does not rely onob-operator
actually. Every resource manager register their task flows in their own packageinit
part.coordinator
and interfaceResourceManager
to a new packagecoordinator
inpkg/
folder, which is another independent module, too.task_manager
. I believe that it does not impact the functionality of task registry. This is the only change that impacts functionalities in this PR.pkg/task
instead of plain string that may cause confusion in some cases. (e.g. mismatch name of task flows and tasks).This PR may somehow reach the requirement of #128