Feature/predictoor iteration 2

[alexcos20]

Fixes # .

Changes proposed in this PR:

• add floatValue to submitTrueVal, for better accuracy tracking
• allow owner to cancel an epoch by passing cancelRound = true in submitTrueVal
• make sure that feeCollector gets fixed rate fees, slashed stakes, revenue per epoch if no predictoors (and not ERC20Deployer)
• handle edge case when all stakers are wrong and will be slashed (feeCollector gets all stakes)

Tests:

• Write test for edge case
• Write test for "allow owner to cancel an epoch by passing cancelRound"

[trizin]

I'm having trouble understanding the purpose of floatValues as it doesn't seem to be utilized in the code.

[trizin]

I suggest renaming:

aggregatedPredictedValuesNumer -> roundSumStakesUp // Round number to the total sum of stakes placed on UP prediction

aggregatedPredictedValuesDenom -> roundSumStakes // Round number to the total sum of stakes placed

[alexcos20]

I'm having trouble understanding the purpose of floatValues as it doesn't seem to be utilized in the code.

emit TruevalSubmitted(slot, trueValue,floatValue,epochStatus[slot]);

at https://github.com/oceanprotocol/contracts/blob/feature/predictoor_iteration_2/contracts/templates/ERC20Template3.sol#LL1138C9-L1138C77

[alexcos20]

roundSumStakes 

done

[trizin]

I'm having trouble understanding the purpose of floatValues as it doesn't seem to be utilized in the code.

emit TruevalSubmitted(slot, trueValue,floatValue,epochStatus[slot]);

at https://github.com/oceanprotocol/contracts/blob/feature/predictoor_iteration_2/contracts/templates/ERC20Template3.sol#LL1138C9-L1138C77

The mapping looks redundant. It's only used at:

floatValues[slot] = floatValue;

Considering it's not used anywhere else and we can query the events to get floatValue I suggest we remove the mapping. What do you think?

[alexcos20]

I'm having trouble understanding the purpose of floatValues as it doesn't seem to be utilized in the code.

emit TruevalSubmitted(slot, trueValue,floatValue,epochStatus[slot]);

at https://github.com/oceanprotocol/contracts/blob/feature/predictoor_iteration_2/contracts/templates/ERC20Template3.sol#LL1138C9-L1138C77

The mapping looks redundant. It's only used at:

floatValues[slot] = floatValue;

Considering it's not used anywhere else and we can query the events to get floatValue I suggest we remove the mapping. What do you think?

yeap, removed

[trizin]

LGTM