check if basetoken is contract #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+188
to
+194
| function isContract(address addr) public view returns(bool){ | ||
| uint32 size; | ||
| assembly { | ||
| size := extcodesize(addr) | ||
| } | ||
| return (size > 0); | ||
| } |
Check warning
Code scanning / Slither
Assembly usage Warning
check if basetoken is contract
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
trizin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #718
Since there is no guaranteed way of telling if an adress is ERC20, let's make sure at least that is an existing contract.
Changes proposed in this PR: