Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector: use proper way to send eth #834

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Collector: use proper way to send eth #834

merged 1 commit into from
Oct 26, 2023

Conversation

alexcos20
Copy link
Member

Closes #826

Changes proposed in this PR:

  • use proper way of sending ETH

@alexcos20 alexcos20 added this to the Contracts v2.0.0 milestone Oct 25, 2023
@alexcos20 alexcos20 requested a review from trizin October 25, 2023 13:36
@alexcos20 alexcos20 self-assigned this Oct 25, 2023
@alexcos20 alexcos20 requested a review from trentmc as a code owner October 25, 2023 13:36
@alexcos20 alexcos20 mentioned this pull request Oct 25, 2023
Closed
@alexcos20 alexcos20 linked an issue Oct 25, 2023 that may be closed by this pull request
Improving withdrawETH() function in OPFCommunityFeeCollector.sol #826
Closed
@openzeppelin-code
Copy link

Collector: use proper way to send eth

Generated at commit: 5abb2ead21a86e0ec146f22018be7a22281873e1

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
Total		 36
13
1
50
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@alexcos20 alexcos20 merged commit fa8abae into v2.0 Oct 26, 2023
9 checks passed
@alexcos20 alexcos20 deleted the feature/collector_safe_withdraw_eth branch October 26, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trizin trizin trizin approved these changes

@trentmc trentmc Awaiting requested review from trentmc

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
Contracts v2.0.0
Development

Successfully merging this pull request may close these issues.

Improving withdrawETH() function in OPFCommunityFeeCollector.sol
2 participants
@alexcos20 @trizin