Remove [test] package from urllib instrumentation

Fixes open-telemetry#2225
ocelotl · Feb 24, 2024 · 4f6b690 · 4f6b690
1 parent 1c21715
commit 4f6b690
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-urllib/pyproject.toml b/instrumentation/opentelemetry-instrumentation-urllib/pyproject.toml
@@ -32,10 +32,6 @@ dependencies = [
 
 [project.optional-dependencies]
 instruments = []
-test = [
-  "httpretty ~= 1.0",
-  "opentelemetry-test-utils == 0.45b0.dev",
-]
 
 [project.entry-points.opentelemetry_instrumentor]
 urllib = "opentelemetry.instrumentation.urllib:URLLibInstrumentor"

diff --git a/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt b/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
@@ -0,0 +1,18 @@
+asgiref==3.7.2
+attrs==23.2.0
+Deprecated==1.2.14
+httpretty==1.1.4
+importlib-metadata==6.11.0
+iniconfig==2.0.0
+packaging==23.2
+pluggy==1.4.0
+py==1.11.0
+py-cpuinfo==9.0.0
+pytest==7.1.3
+pytest-benchmark==4.0.0
+tomli==2.0.1
+typing_extensions==4.9.0
+wrapt==1.16.0
+zipp==3.17.0
+-e ../../../opentelemetry-instrumentation
+-e ../../../instrumentation/opentelemetry-instrumentation-urllib
diff --git a/tox.ini b/tox.ini
@@ -403,7 +403,7 @@ commands_pre =
 
   flask-{213,220,300}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
 
-  urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
+  urllib: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
 
   urllib3v-{1,2}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
 
@@ -562,7 +562,7 @@ commands_pre =
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlite3[test]
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pyramid[test]
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-requests[test]
-  python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
+  python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymysql[test]
   # prerequisite: follow the instructions here https://github.com/PyMySQL/mysqlclient#install