-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fish autocomplete #175
base: master
Are you sure you want to change the base?
Conversation
Auto-detect the correct location using pkg-config to determine the vendor completion directory for fish. Create the script file in that location.
Also add debug logging about the path that we're writing to
- single quote - unnecessary semi-colon - `completions` variable any type
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Pramodya De Alwis <p***@p***.c***.nz>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
Thanks for the contribution! Before we can merge this, we need @p-dealwis to sign the Salesforce.com Contributor License Agreement. |
This ticket relates to the recently closed PR #5 |
Can this be merged? |
@p-dealwis Are you still interested in getting this merged? If so, does the fish autocompletion work with spaces? oclif introduced support for space delineated commands since you first submitted this PR so I'd prefer for any new autocomplete logic to support both spaces and colons |
@mdonnalley I don't use fish anymore...nor do I use oclif. If anyone wants to go ahead and add autocompletion with spaces please be my guest :) Otherwise close the PR.... |
Will this PR be continued ? |
@maastrich as per my comment above, please feel free to carry on from where I left off |
Hey all 👋🏼 Sorry for the radio silence here, I don't think we can provide an ETA about adding support for fish completion (even if we can re-use @p-dealwis's work, we'll have to commit to keep it up to date and at feature parity with bash, zsh and pwsh ). As a side project, I was thinking about start working on a 3rd party oclif plugin for shells not supported by |
I'm currently working on something on a fork of mine, I make a PR soon, it kinds of rework a bit the project in order to be as agnostic as possible about shells that are used. Will create a draft pull_request for review purposes ;) It handles:
Thanks @cristiand391 for your time
|
fyi: I wrote a plugin to use oclif CLIs with |
My branch comprises of changes from a recently closed PR. I have made the required changes to fix the unit tests and added in a missing one.