Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to conditionally disable? #279

Closed
jpage-godaddy opened this issue Apr 18, 2022 · 0 comments · Fixed by #437
Closed

Ability to conditionally disable? #279

jpage-godaddy opened this issue Apr 18, 2022 · 0 comments · Fixed by #437

Comments

@jpage-godaddy
Copy link

We have a CLI created with oclif which uses this plugin. The CLI is for an application shell framework we developed. The version check has been great for development-time prompts to help people get up-to-date with the CLI, but the version check is causing application crashes when it tries to writes out version information to a /.cache directory.

At runtime we don't want this version check to occur. Is there a way to disable the check dynamically so we can suppress the side effect?

mdonnalley pushed a commit that referenced this issue Oct 13, 2023
Fixes #279

This can speed up execution, reduce unnecessary network requests, and clean up log files.
mshanemc pushed a commit that referenced this issue Oct 17, 2023
* feat!: migrate to ESM

BREAKING CHANGES: ESM and node 18 minimum

* feat: add SKIP_UPDATE_CHECK env var (#358)

* chore: bump @oclif/core

* feat: make warning frequency configurable

* feat: allow users to disable update checks

Fixes #279

This can speed up execution, reduce unnecessary network requests, and clean up log files.

* chore: code review

* test: add real tests

* chore: remove rogue console.log

* fix: use scoped env var

* chore: bump oclif/core

* chore: update dev.cmd

* chore: more code review

* chore(release): 2.1.2-qa.0 [skip ci]

* fix: use separate file for tracking last warning

* chore(release): 2.1.2-qa.1 [skip ci]

---------

Co-authored-by: Jake Howard <jake.howard@torchbox.com>
Co-authored-by: svc-cli-bot <svc_cli_bot@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant