Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple calls ImGui::BeginMainMenu crashed #2567

Closed
Ghost-yc opened this issue May 21, 2019 · 1 comment
Closed

Multiple calls ImGui::BeginMainMenu crashed #2567

Ghost-yc opened this issue May 21, 2019 · 1 comment
Labels
bug menus menu bars, menu items

Comments

@Ghost-yc
Copy link

Ghost-yc commented May 21, 2019 •
edited
Loading

Version/Branch of Dear ImGui:

Version: 1.7
Branch: master

Back-end/Renderer/Compiler/OS:

Compiler: Visual Studio 2017
Operating System: Windows 10

My Issue/Question:

when there is no windows display multiple invoked ImGui::BeginMainMenu is crashed in imgui.cpp line 2831

Screenshots/Video

image

here's the modifyed file:
code.zip
@ocornut ocornut added menus menu bars, menu items bug labels May 21, 2019
ocornut added a commit that referenced this issue May 21, 2019
@ocornut
Fixed crash when appending with BeginMainMenuBar() more than once and…
882d2c3 
… no other window are showing. (#2567) + comments
@ocornut
Copy link
Owner

ocornut commented May 21, 2019

Should be fixed, thank you.
I also added comments in ItemAdd() about why we don't check that NavWindow is not NULL (this is a critical path function so we avoid extraneous checks there).

@ocornut ocornut closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug menus menu bars, menu items
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocornut @Ghost-yc