Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing bullets on TreeNodeEx nodes #634

Closed
Cthutu opened this issue May 5, 2016 · 3 comments
Closed

Removing bullets on TreeNodeEx nodes #634

Cthutu opened this issue May 5, 2016 · 3 comments
Labels
tree tree nodes

Comments

@Cthutu
Copy link

Cthutu commented May 5, 2016

Hi,

I've added a new flag to ImGui called ImGuiTreeNodeFlags_NoBullet that removes the bullet. I think it's an important feature since the bullet is not necessarily functional like the arrow. It disables the RenderBullet() call in TreeNodeBehavior(). I had my own TreeNodeEx function to implement a folders/file view (think resource view in Unity) and I updated to see your new version. These bullets suddenly appeared and it looked ugly to me.

I tried to create a pull request but it failed (permissions problem).

What do you think of the idea?

@ocornut
Copy link
Owner

ocornut commented May 6, 2016

We already have an open topic for exactly this, let's preferably keep it there. #581

Puzzled about the permissions problem, normally anyone can submit a PR. What gave you permission problem, github website?

@ocornut ocornut closed this as completed May 6, 2016
@Cthutu
Copy link
Author

Cthutu commented May 6, 2016

Yes, the github website. Should I fork imgui on github first and upload
the branch and try it through github?

On Fri, 6 May 2016 at 02:55 omar notifications@github.com wrote:

We already have an open topic for exactly this, let's preferably keep it
there. #581 #581

Puzzled about the permissions problem, normally anyone can submit a PR.
What gave you permission problem, github website?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#634 (comment)

@ocornut
Copy link
Owner

ocornut commented May 6, 2016

This is how it works normally, yes. However if you are stuck for that feature the PR is an obvious two lines so it's ok to skip this one. But it would have to wait until my mind is back on tree stuff :)

@ocornut ocornut added the tree tree nodes label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree tree nodes
Projects
None yet
Development

No branches or pull requests

2 participants