Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with recent version of dawn #7969

Closed
blitz-research opened this issue Sep 10, 2024 · 1 comment
Closed

Build error with recent version of dawn #7969

blitz-research opened this issue Sep 10, 2024 · 1 comment

Comments

@blitz-research
Copy link

Version/Branch of Dear ImGui:

Version 1.91.1, Branch: master

Back-ends:

imgui_impl_wgpu.cpp

Compiler, OS:

All

Full config/build information:

No response

Details:

The wgpu backend does not build with the latest versions of dawn. The error occurs on this line:

depth_stencil_state.depthWriteEnabled = false;

The 'false' on this line should now be 'WGPUOptionalBool_False'.

I can make a PR for this, but it'll break every one's code if they don't have the latest version of Dawn so it may not be a good idea just yet.

Bye,
Mark

Screenshots/Video:

No response

Minimal, Complete and Verifiable Example code:

No response

@ocornut
Copy link
Owner

ocornut commented Sep 16, 2024

Fixed by 1ac162f !

@ocornut ocornut closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants