Tables: Fix sorting order in demo->tables->sorting #3023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are synced. (some minor one-frame lack of sync when e.g. toggling visibility in context menu)
…idthFixed instead of WidthAlwaysAutoResize if an explicit value is passed to TableSetupColumn()
Return false in user functions, set SkipItems in window, redirect to dummy draw channel.
…or doc) + Fix empty context menu.
…ing users. Fixed some inconsistency with BeginTable/EndTable without row. Move some of the TableBegin() code in TableBeginUpdateColumns(). Allow to submit multiple header lines.
…er a Legacy section.
…le to remove outer vertical borders to mimic old columns. VInner or VOuter only don't have correct padding/spacing.
… of hardcoding them.
…ellRect() include expected paddings. Add demo code. Comments. Remove misleading commented-out flags for now.
…to never be larger than scrolling visible rect width.
…from BackupXXX to HostXXX. Comments.
…xtBaseOffset in EndCell of inactive column).
…api) and exposed flags. Added simple Tree demo.
…ad since we don't actually restore that data currently. Demo: Remove filter from Advanced Table demo since it's breaking with clipping.
…ental one to allow multi-item multi-line in header cells. Demo TableHeader() - will caveat, comments.
… handling of _DefaultSort with _PreferSortXXXflags (@parbo). Comments.
…r layout purpose. (WIP)
|
Hello, |
|
I don't think so, unless Windows 10 changed the convention, usually the triangle means "from smallest (peak) to largest (base)". For example here, a ascending lexicographic sort uses ▲: |
|
Hello @piotrjurga , I have fixed it now with:
Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a minor issue in the demo window in tables branch. The sorting order is reversed:
It was caused by subtracting rhs from lhs in the comparison function, instead of the opposite, as seen in diff.