Fix glClipControl(GL_UPPER_LEFT) handling in opengl3 (fix #3143) #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @u3shit! This is now merged with minor change (I changed the if/else block into a swap and added changelog entries). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3143
I've tested
example_glfw_opengl3andexample_sdl_opengl3with all four combinations ofGL_LOWER_LEFT,GL_UPPER_LEFTandGL_NEGATIVE_ONE_TO_ONE,GL_ZERO_TO_ONE. Technically, the projection matrix is wrong in case ofGL_ZERO_TO_ONE, but since we draw everything with z=0 and we haveglDisable(GL_DEPTH_TEST), it doesn't really matter.