Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ImDrawListSplitter::Merge - corrupted data in buffer (64k+ vertices) with 16-bits indices #3129 #3163

Closed
wants to merge 6 commits into from
Closed

Fix for ImDrawListSplitter::Merge - corrupted data in buffer (64k+ vertices) with 16-bits indices #3129 #3163

wants to merge 6 commits into from

Commits on Jun 4, 2020

  1. Fix for draw list splitter generating incorrect vertex offsets when v… 

    …ertex count exceeds index size (ocornut#3129)
    @ShironekoBen @thedmd
    ShironekoBen authored and thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0d94847 View commit details
    Browse the repository at this point in the history

  2. Thinking about it, we should check for texture ID mismatches too

    @ShironekoBen @thedmd
    ShironekoBen authored and thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f48291b View commit details
    Browse the repository at this point in the history

  3. Always push new command if previous on had user callback.

    @thedmd
    thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c66fd2f View commit details
    Browse the repository at this point in the history

  4. Add dedicated update function for stale pre-cached draw commands.

    @thedmd
    thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3847b51 View commit details
    Browse the repository at this point in the history

  5. Update assert condition as it is possible for PushClipRect() to merge… 

    … drop empty commands.
    @thedmd
    thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    625b29e View commit details
    Browse the repository at this point in the history

  6. Drop test code from DirectX11 main introduced in "Fix for draw list s… 

    …plitter generating incorrect vertex offsets when vertex count exceeds index size (ocornut#3129)"
    @thedmd
    thedmd committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    dcedb28 View commit details
    Browse the repository at this point in the history