Add an argment to disable pixel perfect text alignment to eliminate … #3437
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jitter when placing labels onto objects moving quickly across the screen.
|
Hello and thanks for the PR. API wise I don’t believe adding new bool arguments to all those functions is going to be the right thing to do. We either need to statefully associate that flag to the font or the drawlist, or wait until we refactor the text functions with flags and more elaborate inputs. Either way it may have to wait a little bit. |
|
Awesome! Sorry I missed that number. Glad to hear this may be a baselined feature one day - I'll track this to see when I can sync back up! |
ocornut
changed the title
ocornut
added a commit
that referenced
this pull request
Feb 1, 2021
…ceil. (#3776) his is in order for text wrapping to have enough space when provided width precisely calculated with CalcTextSize().x. Amend 7b0bf23. Note that the rounding of either positions and widths are technically undesirable (e.g. #3437, #791) but variety of code is currently on it so we are first fixing current behavior before we'll eventually change it.
ocornut
force-pushed
the
master
branch
2 times, most recently
from
0c1e5bd
to
bb6a60b
Compare
ocornut
force-pushed
the
master
branch
2 times, most recently
from
8b83e0a
to
d735066
Compare
ocornut
force-pushed
the
master
branch
2 times, most recently
from
b3b85d8
to
0755767
Compare
ocornut
force-pushed
the
master
branch
3 times, most recently
from
c817acb
to
8d39063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…jitter when placing labels onto objects moving quickly across the screen.
I'm using the GetBackgroundDrawList()->addText() paired with rounded rects for backgrounds to draw screen space labels for jets flying around in an airpsace. The labels would appear to "bounce" around when the jet flies. I identified this was due to the pixel perfect positioning of the text object. Confirmed that adding this to my project solved the issue and the text labels still looked great.
Thanks!