Columns: Make sure the ClipRect is valid. #3475
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a window with columns is dragged horizontally outside of the viewport, the
ClipRect
of a column may fall entirely outsideClipRect
of the containing window. Intersecting thoseClipRects
usingClipWith()
member function may cause the resulting rectangle to be invalid (meaning:ClipRect.Min.x > ClipRect.Max.x
).Fix this issue by using
ClipWithFull()
instead.