Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webgpu API to be compatible with chrome 4633 #4512

Conversation

bfierz
Copy link
Contributor

@bfierz bfierz commented Sep 5, 2021

This change is a follow-up to #4472 and implements WebGPU changes up to dawn tagged for chrome 4633.
This was done according to https://hackmd.io/OxDovqjoTXqC_r_WY-aM1Q , however, the current version of Emscriptem seems not up to date yet.

@ocornut
Copy link
Owner

ocornut commented Sep 8, 2021

however, the current version of Emscriptem seems not up to date yet.

Thanks!
It's failing in CI due to that. I guess we'll have to wait until Emscripten update to merge this! If you see that happening let us know but I guess we'll check occasionally.

@ocornut ocornut marked this pull request as ready for review October 6, 2021 10:02
@ocornut
Copy link
Owner

ocornut commented Oct 6, 2021

Now merged as Emscripten seemingly was updated!
https://github.com/ocornut/imgui/runs/3817266378
Thank you!

@ocornut ocornut closed this Oct 6, 2021
@ocornut
Copy link
Owner

ocornut commented Feb 28, 2022

FYI for anyone interested, WebGPU backend broke again with latest:
https://github.com/ocornut/imgui/runs/5357933672?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants