Fix printf format warnings on mingw clang #4626
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
When compiling with mingw bundled clang, it will complain that the
gnu_printf
format argument is not supported.using the other macro with
printf
however works fine.I changed the conditions so it will use
format(printf, ...)
on mingw clang, but still useformat(gnu_printf,...)
for mingw gccTested with mingw clang/gcc and also native windows clang. All report no errors with this fix.