Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed font ascent and descent calculation when a font hits exact integer values #7404

Conversation

GamingMinds-DanielC
Copy link
Contributor

Here is the fix mentioned in #7399 as a PR.

This fix doesn't affect the default font at all since it doesn't hit exact integer values, so no side effects in this regard. For custom fonts that do hit exact integer values, this fix calculates the ascent and descent with more precision and will improve the font rendering a little. If the vertical glyph offset for a custom font has been used to compensate for the imprecision before, this compensation will no longer be necessary.

ocornut pushed a commit that referenced this pull request Apr 15, 2024
@ocornut
Copy link
Owner

ocornut commented Apr 15, 2024

Merged as b475309, thank you! posting further comments in #7399

@ocornut ocornut closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants