-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backends: SDL3: Re-enable calling SDL_StartTextInput()/SDL_StopTextInput() #7452
Conversation
thanks for this, it appears to be working for me! |
Oh thanks, now I understand why inputs are not working since I updated SDL and ImGui 😅 |
IME doesn't seem to work with this. I'm really puzzled by SDL3 API to accept character inputs, as it is likely we may want them in situation where we don't want an OSD necessarily showing on all platforms. |
I have pushed your fix, however, note that IME inputs are currently essentially broken because somehow the keys (e.g. arrows, enter) gets sent to both the IME and the app, and app reacting to it usually means unfocusing the text widget. I'm not sure how to fix that, I would appreciate if someone with SDL3 interest could investigate it. I'm puzzled by SDL3 messing with system IME, when things would just work by default if it doesn't mess with it. I'm also puzzled by the |
Ah that's somewhat unfortunate. I am not too familiar with how IMEs work in general.
There is the hint |
That would be incorrect and misleading. I think SDL3 is broken and someone needs to raise this to them.
Things currently only work with this hint set to 1, as mentioned in backends and examples. |
SDL3 no longer enables text input by default. (libsdl-org/SDL#9309)
And should also play nicer with IME / virtual keyboards.
Without this "revert", no text inputs can be done on recent SDL3.
Amend: a7703fe
This patch is required for any of the SDL3 preview releases.