-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function IsBlockedByModal
and new flag ImGuiInputFlags_RouteUnlessModal
#7646
base: master
Are you sure you want to change the base?
Conversation
I'll leave this open until I have can investigate everything properly, I agree #7643 is an issue. But it's almost certainly a little more complex than that, given one of the property of Moreover, calling
Not sure where you got that from :) I admit they brought more problems that I would have expected, but we'll keep fixing things as required.
I realize the codebase is not simple to work with. As a general rule of thumb:
|
Ah, now that you mention it... For first, the workaround you mention of calling For second, there is this one little, insignificant issue... if I open a modal, and then over it I open a pop-up (such as the "Combo" in the "Stacked modals" demo, and then I click outside of the modal window, in the void dimmed space, I would expect the popup to dismiss, but it does nothing! I can even resize the "Stacked 1" window to make it small, and then open the "Color picker" popup, move it to cover the whole parent window, and I will be unable to dismiss it (I can move the "color picker" but that's not the point): I don't use popups over modals, so this doesn't affect me and I didn't bother to report it before... But these kinds of small paper cut issues, that plague other UI libraries, are rare in Dear ImGui ( ❤️ ), so the fact that this has survived for so long should mean something. |
Please open a separate issue. |
Created #7654 for the that unrelated modal issue. |
This is my draft for implementing #7643.
I'm aware that modal windows are not a priority, because they are seldom useful in most ImGui use cases. But I happen to need them, so I'm trying to push them a little bit.
I'm not sure that is the proper way to implement it, that routing thing is still a bit of a mystery to me, but it seems to work just fine.
I'll be happy to receive any correction or feedback.