Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation for ocp-cluster-etcd-operator #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Automation for ocp-cluster-etcd-operator #94

wants to merge 1 commit into from

Conversation

swapnil-bobade27
Copy link
Contributor

@swapnil-bobade27 swapnil-bobade27 commented Dec 9, 2024 •
edited
Loading

Automation for ocp-cluster-etcd-operator and kube-burner workload test

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2024
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch 2 times, most recently from f9531f8 to 931c23f Compare December 9, 2024 11:47
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch 2 times, most recently from 2f8c340 to e3027b6 Compare December 10, 2024 12:14
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from e3027b6 to e052b47 Compare December 12, 2024 10:35
@varad-ahirwadkar
Copy link
Contributor

Ideally we should have a separate PR for adding new role ocp-kube-burner.

@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from e052b47 to 4c263fa Compare December 16, 2024 12:24
@swapnil-bobade27
Copy link
Contributor Author

Ideally we should have a separate PR for adding new role ocp-kube-burner.

new role for kube-burner added

@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from 4c263fa to 2b126c9 Compare December 18, 2024 11:17
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from 2b126c9 to d05c20d Compare December 20, 2024 06:12
@swapnil-bobade27 swapnil-bobade27 changed the title Automation for ocp-cluster-etcdc-operator Automation for ocp-cluster-etcd-operator Dec 20, 2024
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from d05c20d to 33c0577 Compare December 20, 2024 06:18
@varad-ahirwadkar
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swapnil-bobade27, varad-ahirwadkar
Once this PR has been reviewed and has the lgtm label, please assign yussufsh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swapnil-bobade27
Signed-off-by: Swapnil Bobade <swapnil.bobade@ibm.com>
a0d4b96 
Adding roles for ocp-kube-burner and ocp-cluster-etcd-operator

Signed-off-by: Swapnil Bobade <swapnil.bobade@ibm.com>

Signed-off-by: Swapnil Bobade <swapnil.bobade@ibm.com>
@swapnil-bobade27 swapnil-bobade27 force-pushed the ocp-cluster-etcd-operator branch from 33c0577 to a0d4b96 Compare December 23, 2024 08:33
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@ppc64le-cloud-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

yussufsh
yussufsh reviewed Dec 23, 2024
View reviewed changes
playbooks/roles/ocp-kube-burner/files/cluster-density.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks like some tasks. The files dir is to keep static files.
Please refer to https://docs.ansible.com/ansible/2.8/user_guide/playbooks_best_practices.html#directory-layout

yussufsh
yussufsh reviewed Dec 23, 2024
View reviewed changes
playbooks/roles/ocp-kube-burner/files/kubelet-density.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why so many tasks to add line after line?
Please use template files under templates dir.

@yussufsh
Copy link
Contributor

/cc @aman4433
The role directory structure is not proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurajGudaji SurajGudaji SurajGudaji left review comments

@yussufsh yussufsh yussufsh left review comments

@varad-ahirwadkar varad-ahirwadkar Awaiting requested review from varad-ahirwadkar

@aman4433 aman4433 Awaiting requested review from aman4433

Assignees

@varad-ahirwadkar varad-ahirwadkar

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swapnil-bobade27 @varad-ahirwadkar @ppc64le-cloud-bot @yussufsh @SurajGudaji