This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Add support for local registry #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yussufsh
reviewed
Nov 3, 2020
| registry_image: "${local_registry.registry_image}" | ||
| local_repo: "${local_registry.ocp_release_repo}" | ||
| product_repo: "openshift-release-dev" | ||
| release_name: "ocp-release" |
There was a problem hiding this comment.
@Prajyot-Parab better have this as a variable? The way we had done this for PowerVS?
There was a problem hiding this comment.
yes, that makes sense but then in ocp4-playbook, we stick to this quay.io/openshift-release-dev/ocp-release so won't really matter. If @pravin-dsilva Can try to parameterize it in ocp4-playbook as well then we can make it a variable.
There was a problem hiding this comment.
Ok then it makes sense.. but you think it is good to make it a user variables please open new PRs.
There was a problem hiding this comment.
Sure we can get this PR merged and as a next step, I will focus on converting whatever remains into variables inline with ocp4-playbook changes.
pravin-dsilva
force-pushed
the
local-registry
branch
2 times, most recently
from
89b7b41 to
b39924f
Compare
Signed-off-by: Pravin Dsilva <pravin.d-silva@ibm.com>
pravin-dsilva
force-pushed
the
local-registry
branch
from
b39924f to
5cf6f80
Compare
Prajyot-Parab
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pravin Dsilva pravin.d-silva@ibm.com