Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README warning about the README #100

Merged

Conversation

clnperez
Copy link
Contributor

update the warning about which version of the README to work from.

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

@ltccci ltccci added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2020
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2020
@bpradipt
Copy link
Contributor

Thanks @clnperez

@bpradipt
Copy link
Contributor

@clnperez sorry, this will need a rebase ..

update the warning about which version of the README to work from.

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez clnperez force-pushed the readme-readme-wording branch from 38c49a3 to e4b45b0 Compare September 23, 2020 17:16
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@bpradipt
Copy link
Contributor

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, clnperez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpradipt bpradipt merged commit 4bdccf5 into ocp-power-automation:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants