Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoting error bullets to sections to HTML anchors work #103

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

miyamotoh
Copy link
Contributor

Changing doc style from bullets for each error to headings/sections so pointing to a specific known error works with URL with HTML anchors (#foo).

Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com

@ltccci ltccci added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2020

## Accessing IBM Container Registry fails

- **Error**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this issue. This is currently taken care in deployment code itself

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miyamotoh this is still there ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that whole MTU=1450 thing is becoming non-issue? Misunderstood. Will be in my next push...

@bpradipt
Copy link
Contributor

Thanks @miyamotoh .. While you are modifying this. Can you please add these additional issues.
For all these cases, the apply command need to be re-run.

module.install.null_resource.install (remote-exec): information.
module.install.null_resource.install (remote-exec): changed: [192.168.25.12] => {"ansible_facts": {"discovered_interpreter_python": "/usr/libexec/platform-python"}, "changed": true, "cmd": "if lsmod|grep -q 'ibmveth'; then\n  sudo sysctl -w net.ipv4.route.min_pmtu=1450;\n  sudo sysctl -w net.ipv4.ip_no_pmtu_disc=1;\n  echo 'net.ipv4.route.min_pmtu = 1450' | sudo tee --append /etc/sysctl.d/88-sysctl.conf > /dev/null;\n  echo 'net.ipv4.ip_no_pmtu_disc = 1' | sudo tee --append /etc/sysctl.d/88-sysctl.conf > /dev/null;\nfi\n", "delta": "0:00:00.078644", "end": "2020-09-18 16:25:46.414601", "rc": 0, "start": "2020-09-18 16:25:46.335957", "stderr": "", "stderr_lines": [], "stdout": "net.ipv4.route.min_pmtu = 1450\nnet.ipv4.ip_no_pmtu_disc = 1", "stdout_lines": ["net.ipv4.route.min_pmtu = 1450", "net.ipv4.ip_no_pmtu_disc = 1"]}

module.install.null_resource.install (remote-exec): NO MORE HOSTS LEFT *************************************************************

module.install.null_resource.install (remote-exec): PLAY RECAP *********************************************************************
module.install.null_resource.install (remote-exec): 192.168.25.105             : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.12              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.121             : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.15              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.235             : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.39              : ok=1    changed=0    unreachable=1    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.5               : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.82              : ok=28   changed=22   unreachable=0    failed=0    skipped=11   rescued=0    ignored=0

module.install.null_resource.config (remote-exec): TASK [Downloading OCP4 Installer] **********************************************
module.install.null_resource.config: Still creating... [1m40s elapsed]
module.install.null_resource.config (remote-exec): fatal: [localhost]: FAILED! => {"changed": false, "dest": "/usr/local/src/openshift-install-linux.tar.gz", "elapsed": 10, "msg": "Request failed: <urlopen error _ssl.c:880: The handshake operation timed out>", "url": "https://mirror.openshift.com/pub/openshift-v4/ppc64le/clients/ocp/4.5.4/openshift-install-linux.tar.gz"}

module.install.null_resource.install (remote-exec): fatal: [192.168.25.167]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host 192.168.25.167 port 22: Connection timed out", "unreachable": true}

module.install.null_resource.install (remote-exec): NO MORE HOSTS LEFT *************************************************************

module.install.null_resource.install (remote-exec): PLAY RECAP *********************************************************************
module.install.null_resource.install (remote-exec): 192.168.25.107             : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.165             : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.167             : ok=1    changed=0    unreachable=1    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.212             : ok=28   changed=22   unreachable=0    failed=0    skipped=11   rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.64              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.76              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.78              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
module.install.null_resource.install (remote-exec): 192.168.25.81              : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

> module.install.null_resource.install (remote-exec): 192.168.25.39 : ok=1 changed=0 unreachable=1 failed=0 skipped=0 rescued=0 ignored=0
> module.install.null_resource.install (remote-exec): 192.168.25.5 : ok=2 changed=1 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
> module.install.null_resource.install (remote-exec): 192.168.25.82 : ok=28 changed=22 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put some additional empty lines to make the distinction between different types of error?
Currently it looks like the entire message is part of same error..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding bullet points...

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @miyamotoh

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, miyamotoh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2020
@bpradipt
Copy link
Contributor

Can you also raise a PR against the release-4.5 branch ?

@ltccci ltccci merged commit c5bd992 into ocp-power-automation:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants