-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promoting error bullets to sections to HTML anchors work #103
Conversation
docs/known_issues.md
Outdated
|
||
## Accessing IBM Container Registry fails | ||
|
||
- **Error**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this issue. This is currently taken care in deployment code itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miyamotoh this is still there ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that whole MTU=1450 thing is becoming non-issue? Misunderstood. Will be in my next push...
Thanks @miyamotoh .. While you are modifying this. Can you please add these additional issues.
|
d1ad579
to
be734a1
Compare
docs/known_issues.md
Outdated
> module.install.null_resource.install (remote-exec): 192.168.25.39 : ok=1 changed=0 unreachable=1 failed=0 skipped=0 rescued=0 ignored=0 | ||
> module.install.null_resource.install (remote-exec): 192.168.25.5 : ok=2 changed=1 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 | ||
> module.install.null_resource.install (remote-exec): 192.168.25.82 : ok=28 changed=22 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put some additional empty lines to make the distinction between different types of error?
Currently it looks like the entire message is part of same error..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding bullet points...
Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
be734a1
to
7add8ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @miyamotoh
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, miyamotoh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you also raise a PR against the release-4.5 branch ? |
Changing doc style from bullets for each error to headings/sections so pointing to a specific known error works with URL with HTML anchors (
#foo
).Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com