Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bastion HA with external vip #114

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Support bastion HA with external vip #114

merged 6 commits into from
Oct 9, 2020

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Oct 8, 2020

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2020
@yussufsh
Copy link
Contributor Author

yussufsh commented Oct 8, 2020

/cc @Prajyot-Parab @bpradipt
I know this is a big change, but I took the time to divide it into logical commits for your review.

@yussufsh
Remove bastion_host and use public ip data source
9f14898 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Set bastion count variable
11ac719 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Add helpernode_inventory and related changes
0952477 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Support bation HA
416b739 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Use of external ip in HA setup
9c6090c 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
bpradipt
bpradipt reviewed Oct 9, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@yussufsh yussufsh requested a review from bpradipt October 9, 2020 09:53
@bpradipt
Copy link
Contributor

bpradipt commented Oct 9, 2020

/approve

@bpradipt
Copy link
Contributor

bpradipt commented Oct 9, 2020

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
bpradipt
bpradipt previously approved these changes Oct 9, 2020
View reviewed changes
@yussufsh
Restrict bastion count to 2 and update public vrrp priority
9ce5a66 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
Prajyot-Parab
Prajyot-Parab approved these changes Oct 9, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@yussufsh yussufsh requested a review from bpradipt October 9, 2020 17:10
@bpradipt
Copy link
Contributor

bpradipt commented Oct 9, 2020

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Oct 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 07eb3ba into ocp-power-automation:master Oct 9, 2020
This was referenced Nov 12, 2020
Closed
Closed
@ssinha20
Copy link

@yussufsh : Since the PR is merged, can the issue be closed or do you plan further development?

@yussufsh
Copy link
Contributor Author

@yussufsh : Since the PR is merged, can the issue be closed or do you plan further development?

Wrong PR?

@ssinha20
Copy link

#116 - is this the correct issue linked with this PR?

@yussufsh
Copy link
Contributor Author

#116 - is this the correct issue linked with this PR?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yussufsh @bpradipt @ltccci @ssinha20 @Prajyot-Parab