Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale repo fix and improve subscription check #130

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Remove stale repo fix and improve subscription check #130

merged 1 commit into from
Oct 21, 2020

Conversation

yussufsh
Copy link
Contributor

  1. Removed stale repo fix as this stale repos is on the user creating the image. Since most of the resources have fresh image we should not have this.
  2. For centos users rhel_subscription_username == "<subscription-id>" being set in var.tfvars would have issues. We should not try the subscription if the value is unchanged.
    Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@yussufsh
Remove stale repo fix and improve subscription check
997dc5b 
1. Removed stale repo fix as this stale repos is on the user creating the image. Since most of the resources have fresh image we should not have this.
2. For centos users `rhel_subscription_username  == "<subscription-id>"` being set in var.tfvars would have issues. We should not try the subscription if the value is unchanged.
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2020
@yussufsh
Copy link
Contributor Author

/cc @bpradipt

@ltccci ltccci requested a review from bpradipt October 19, 2020 15:13
Prajyot-Parab
Prajyot-Parab approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
bpradipt
bpradipt approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Oct 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit e1dcdcf into ocp-power-automation:master Oct 21, 2020
@bpradipt bpradipt mentioned this pull request Oct 28, 2020
Merged
@yussufsh yussufsh deleted the yussufsh-patch-1 branch February 3, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @ltccci @bpradipt @Prajyot-Parab