validation and type check on variables #935 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltccci
added
the
size/M
yussufsh
requested changes
Oct 28, 2020
ltccci
added
size/L
yussufsh
reviewed
Oct 30, 2020
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
8fa55a7 to
39558f8
Compare
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
39558f8 to
3e64d0c
Compare
ltccci
added
size/M
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
54617fc to
a2d5bbf
Compare
yussufsh
reviewed
Nov 19, 2020
|
@Elayaraja-Dhanapal can you please address the comments and rebase the PR. Would like to close this asap. |
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
815d91a to
769ed62
Compare
|
rebase/merge (769ed62) contains all the changes. @yussufsh @Prajyot-Parab please validate. |
|
@Elayaraja-Dhanapal please also squash the multiple commits into a single one |
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
a5545f0 to
769ed62
Compare
|
@yussufsh @Prajyot-Parab could you please validate the pull request. Thanks! |
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
769ed62 to
e912e71
Compare
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
a286365 to
aa4665d
Compare
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
352a05a to
aa4665d
Compare
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
8a18604 to
afb1dfd
Compare
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
afb1dfd to
990f025
Compare
|
@yussufsh @Prajyot-Parab Please review. |
|
/lgtm |
|
/retest |
yussufsh
previously approved these changes
Dec 8, 2020
|
@Elayaraja-Dhanapal this needs a rebase again.. |
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
990f025 to
6e8b847
Compare
Signed-off-by: Elayaraja Dhanapal <eldhanap@in.ibm.com>
Elayaraja-Dhanapal
force-pushed
the
release-4.6-935
branch
from
437692b to
0ae20b2
Compare
|
Done. Please review. Thanks. @yussufsh @Prajyot-Parab |
|
lgtm! |
|
/lgtm |
bpradipt
approved these changes
Dec 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, Elayaraja-Dhanapal, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform validation (fewer variables) and type constraints (all variables) added.