Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of master branch for latest OCP pre-release versions #138

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Nov 3, 2020

Signed-off-by: Pradipta Banerjee pradipta.banerjee@gmail.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@bpradipt bpradipt requested a review from yussufsh November 3, 2020 12:02
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@@ -22,7 +22,7 @@ For general PowerVS usage instructions please refer to the following links:
- https://www.youtube.com/playlist?list=PLVrJaTKVPbKM_9HU8fm4QsklgzLGUwFpv


:heavy_exclamation_mark: **Ensure that you're working from the desired release-specific version of this `README` as you deploy by first selecting the appropriate branch from the drop-down above. At the time of this writing, the latest release is 4.5: [README](https://github.com/ocp-power-automation/ocp4-upi-powervs/tree/release-4.5). The `README` document located in the `master` branch changes frequently and should not be considered final.**
:information_source: **This branch must be used with latest OCP pre-release versions only. For stable releases please checkout specific release branches - {release-4.5, release-4.6 ...} and follow the docs.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say ...and follow the respective README. Better to give the README links here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be hard to provide links to every release branch. We'll add 4.7 as well. IMHO let it be for now and we can revisit later

yussufsh
yussufsh previously approved these changes Nov 4, 2020
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Prajyot-Parab
Prajyot-Parab previously approved these changes Nov 4, 2020
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt bpradipt dismissed stale reviews from Prajyot-Parab and yussufsh via 5ea6eda November 4, 2020 06:10
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ltccci
Copy link
Contributor

ltccci commented Nov 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit ac94f6c into ocp-power-automation:master Nov 4, 2020
@bpradipt bpradipt deleted the doc-master branch November 4, 2020 08:01
@bpradipt bpradipt restored the doc-master branch November 4, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants