Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external VIP from the public network port #149

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

yussufsh
Copy link
Contributor

  1. Update IBM provider to the latest version
  2. Use external VIP from network port

Fixes #45

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

The latest version has couple of fixes for PI instance
1. IBM-Cloud/terraform-provider-ibm#1930
2. IBM-Cloud/terraform-provider-ibm#2046

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
Fixes ocp-power-automation#45

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2020
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ltccci
Copy link
Contributor

ltccci commented Nov 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 1dbcda3 into ocp-power-automation:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reserve external network address for the use of public VIP for HA clusters
4 participants