Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the install playbook failure due to default chrony config #173

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix the install playbook failure due to default chrony config #173

merged 1 commit into from
Dec 14, 2020

Conversation

yussufsh
Copy link
Contributor

Fixes #172

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@yussufsh
Fix the install playbook failure due to default chrony config
5552d11 
Fixes ocp-power-automation#172

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2020
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt
This will fix the recently introduced issue in code for ocp pre-release deployments in master branch.

Prajyot-Parab
Prajyot-Parab approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@yussufsh
Copy link
Contributor Author

/retest

bpradipt
bpradipt approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh
Copy link
Contributor Author

/retest one last time

@ltccci
Copy link
Contributor

ltccci commented Dec 14, 2020

@yussufsh: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-ocp4-upi-powervs-terraform-validate

Use /test all to run all jobs.

In response to this:

/retest one last time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor Author

/test all
... last time

@bpradipt
Copy link
Contributor

Let's wait else will force merge

@bpradipt bpradipt merged commit 831ac90 into ocp-power-automation:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install playbook execution failing with default chrony config
4 participants
@yussufsh @ltccci @bpradipt @Prajyot-Parab