Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Ansible installation to use yum #186

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Change Ansible installation to use yum #186

merged 1 commit into from
Dec 18, 2020

Conversation

yussufsh
Copy link
Contributor

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2020
@yussufsh
Copy link
Contributor Author

/hold

@ltccci ltccci added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@yussufsh
Copy link
Contributor Author

/hold
Doing last round of testing with rhel_subscription_password = "<subscription-password>"
In meantime would like some review comments if any...
/cc @Prajyot-Parab @bpradipt

@yussufsh
Change Ansible installation to use yum
c01acc0 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh yussufsh requested a review from bpradipt December 18, 2020 09:58
Prajyot-Parab
Prajyot-Parab approved these changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2020
@yussufsh
Copy link
Contributor Author

/unhold

@ltccci ltccci removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
bpradipt
bpradipt approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 834a3b4 into ocp-power-automation:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @ltccci @bpradipt @Prajyot-Parab