Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster upgrade using stable versions #191

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

yussufsh
Copy link
Contributor

Fixes #190

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2020
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt

Prajyot-Parab
Prajyot-Parab previously approved these changes Dec 21, 2020
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
Prajyot-Parab
Prajyot-Parab previously approved these changes Dec 21, 2020
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
@Prajyot-Parab Prajyot-Parab self-requested a review December 21, 2020 08:16
@Prajyot-Parab Prajyot-Parab removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
Fixes ocp-power-automation#190

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
@yussufsh
Copy link
Contributor Author

Sorry for so many force pushes... was changing the pause time from 90m to 70m. My test PowerVS cluster was upgraded in 65 mins.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh yussufsh merged commit 90dc165 into ocp-power-automation:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image upgrade fails when providing the upgrade_image
4 participants