Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update var.tfvars-doc.md #194

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Update var.tfvars-doc.md #194

merged 1 commit into from
Dec 23, 2020

Conversation

rpsene
Copy link

@rpsene rpsene commented Dec 23, 2020

Add all missing data centers.

@rpsene rpsene requested a review from bpradipt December 23, 2020 14:06
@ltccci ltccci added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 23, 2020
@bpradipt
Copy link
Contributor

@rpsene thanks. Can you please add signed-off-by in the commit. Rest lgtm

Update var.tfvars-doc.md
f7b865e 
Add all missing data centers.

Signed-off-by: Rafael Peria de Sene <rpsene@br.ibm.com>
@rpsene
Copy link
Author

rpsene commented Dec 23, 2020

@bpradipt done.

bpradipt
bpradipt approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 23, 2020
@bpradipt bpradipt requested a review from yussufsh December 23, 2020 17:38
yussufsh
yussufsh approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, rpsene, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 800061a into ocp-power-automation:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpsene @bpradipt @ltccci @yussufsh