Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for enabling chrony #38

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Changes for enabling chrony #38

merged 1 commit into from
Aug 13, 2020

Conversation

yussufsh
Copy link
Contributor

No description provided.

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2020
@yussufsh
Copy link
Contributor Author

/cc @bpradipt

@ltccci ltccci requested a review from bpradipt August 12, 2020 12:24
@yussufsh
Copy link
Contributor Author

@yussufsh: The following test failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-ocp4-upi-powervs-terraform-validate 97bdedb link /test pull-ocp4-upi-powervs-terraform-validate

Full PR test history. Your PR dashboard.

@mkumatag Good news is Terraform 0.13 is released. Bad news we do not need it for now. :-)

@yussufsh
Copy link
Contributor Author

/retest

1 similar comment
@mkumatag
Copy link
Member

/retest

@mkumatag
Copy link
Member

@yussufsh: The following test failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-ocp4-upi-powervs-terraform-validate 97bdedb link /test pull-ocp4-upi-powervs-terraform-validate
Full PR test history. Your PR dashboard.

@mkumatag Good news is Terraform 0.13 is released. Bad news we do not need it for now. :-)

Job is back to green now.

bpradipt
bpradipt approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @yussufsh

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@ltccci
Copy link
Contributor

ltccci commented Aug 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit f0ab979 into ocp-power-automation:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @mkumatag @ltccci @bpradipt