Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ocp4-playbook tag for named hotfix #39

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

Prajyot-Parab
Copy link
Collaborator

Signed-off-by: Prajyot Parab prajyot.parab@ibm.com

Signed-off-by: Prajyot Parab <prajyot.parab@ibm.com>
@ltccci ltccci added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2020
@Prajyot-Parab
Copy link
Collaborator Author

/assign @yussufsh @bpradipt

@ltccci
Copy link
Contributor

ltccci commented Aug 12, 2020

@Prajyot-Parab: GitHub didn't allow me to assign the following users: yussufsh.

Note that only ocp-power-automation members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yussufsh @bpradipt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @Prajyot-Parab

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020
@ltccci
Copy link
Contributor

ltccci commented Aug 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@bpradipt
Copy link
Contributor

@Prajyot-Parab going forward we'll need to fix the test issues

@Prajyot-Parab
Copy link
Collaborator Author

@Prajyot-Parab going forward we'll need to fix the test issues

@bpradipt yes, for now, we will need to have tf v0.12 for validations to work. Also can you please merge this one if possible.

@mkumatag
Copy link
Member

@Prajyot-Parab going forward we'll need to fix the test issues

@bpradipt yes, for now, we will need to have tf v0.12 for validations to work. Also can you please merge this one if possible.

lemme force the version of tf we are using to validate the scripts,

@mkumatag
Copy link
Member

@yussufsh can you please ack this - ppc64le-cloud/test-infra#30

@yussufsh
Copy link
Contributor

/retest

1 similar comment
@mkumatag
Copy link
Member

/retest

@ltccci ltccci merged commit e6f6266 into ocp-power-automation:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants