Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest playbook changes #447

Merged

Conversation

Prajyot-Parab
Copy link
Collaborator

Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2022
@Prajyot-Parab
Copy link
Collaborator Author

/cc @yussufsh ptal

@ppc64le-cloud-bot
Copy link
Contributor

@Prajyot-Parab: GitHub didn't allow me to request PR reviews from the following users: ptal.

Note that only ocp-power-automation members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yussufsh ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor

@Prajyot-Parab did we test this?

@Prajyot-Parab
Copy link
Collaborator Author

@Prajyot-Parab did we test this?

@aditijadhav38 update your test results here

@aditijadhav38
Copy link

aditijadhav38 commented Nov 15, 2022

@yussufsh Attaching complete logs of the cluster deployment
prajyot-changes-cluster-logs.txt
Also we tested these changes with split commit 10f81375c43ccac751c632e876d05f0d4490e048

@@ -76,10 +85,13 @@ use_zone_info_for_names = true # If set it to false, the zone info would not be

 #helpernode_repo            = "https://github.com/RedHatOfficial/ocp4-helpernode"
 #helpernode_tag             = ""
-#install_playbook_repo      = "https://github.com/ocp-power-automation/ocp4-playbooks"
-#install_playbook_tag       = ""
+install_playbook_repo      = "https://github.com/ocp-power-automation/ocp4-playbooks"
+install_playbook_tag       = "10f81375c43ccac751c632e876d05f0d4490e048"

/cc @Prajyot-Parab

@ppc64le-cloud-bot
Copy link
Contributor

@aditijadhav38: GitHub didn't allow me to request PR reviews from the following users: Prajyot-Parab.

Note that only ocp-power-automation members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@yussufsh Attaching complete logs of the cluster deployment
prajyot-changes-cluster-logs.txt
Also we tested these changes with split commit 10f81375c43ccac751c632e876d05f0d4490e048
/cc @Prajyot-Parab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/non-mergeable labels Nov 15, 2022
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 2c48463 into ocp-power-automation:master Nov 15, 2022
@yussufsh
Copy link
Contributor

@yussufsh Attaching complete logs of the cluster deployment prajyot-changes-cluster-logs.txt Also we tested these changes with split commit 10f81375c43ccac751c632e876d05f0d4490e048

@aditijadhav38 thanks!

@yussufsh yussufsh changed the title Fix install module flow Use the latest playbook changes Nov 16, 2022
@aishwaryabk
Copy link
Collaborator

/cherrypick release-4.11

@ppc64le-cloud-bot
Copy link
Contributor

@aishwaryabk: new pull request created: #448

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants