Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashicorp null and random providers to enable darwin/arm64 support #451 #452

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Update hashicorp null and random providers to enable darwin/arm64 support #451 #452

merged 1 commit into from
Dec 20, 2022

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Dec 6, 2022 •
edited by yussufsh
Loading

  • updated to enable support for darwin/arm64

Signed-off-by: Paul Bastide pbastide@us.ibm.com

Fixes #451

@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2022
@ppc64le-cloud-bot
Copy link
Contributor

Hi @prb112. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prb112 prb112 closed this Dec 6, 2022
@prb112 prb112 reopened this Dec 7, 2022
@prb112
Copy link
Contributor Author

prb112 commented Dec 7, 2022

@yussufsh per issue #451 and the chat there, I have re-opened.

@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2022

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2022
@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2022 •
edited
Loading

@prb112 could you please amend your commit message mentioning the issue# you are trying to fix? Please read through our pull-request-process.

@prb112
Update hashicorp null and random providers to enable darwin/arm64 sup…
b6f9087 
…port ocp-power-automation#451

Updates hashicorp null and random to support darwin/arm64
Resolves issue ocp-power-automation#451

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Dec 8, 2022

I have updated the body of the commit, previously only the title of the commit contained the reference.

yussufsh
yussufsh approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2022

/cc @Prajyot-Parab
/uncc @mkumatag

@ppc64le-cloud-bot ppc64le-cloud-bot requested review from Prajyot-Parab and removed request for mkumatag December 8, 2022 13:58
@yussufsh
Copy link
Contributor

/cc @Prajyot-Parab

Prajyot-Parab
Prajyot-Parab approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, prb112, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/non-mergeable labels Dec 20, 2022
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit ef7c787 into ocp-power-automation:master Dec 20, 2022
@prb112
Copy link
Contributor Author

prb112 commented Dec 25, 2022

Thank you so much, very helpful to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@yussufsh yussufsh yussufsh approved these changes

Assignees

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update hashicorp null and random providers to enable darwin/arm64 support
4 participants
@prb112 @ppc64le-cloud-bot @yussufsh @Prajyot-Parab