Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revamp install steps to start nodes in sequence #460

Merged
merged 10 commits into from
Jan 31, 2023
Merged

revamp install steps to start nodes in sequence #460

merged 10 commits into from
Jan 31, 2023

Conversation

yussufsh
Copy link
Contributor

No description provided.

yussufsh and others added 9 commits January 30, 2023 04:59
@yussufsh
Include stop start logic for ocp 4.12 install
369f480 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
Update ibm provider version to use instance actions
91964e4 
Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@yussufsh
remove timeout from ignition
1722c15 
Reason for removal is that rhcos does not automatically reboot after timeout now ref: coreos/fedora-coreos-config#1665

Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
start using playbook main branch
49b9440 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
improve setup disk step and wait on it
a395843 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
Added .gitignore
6f741b0 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
Added .terraform.lock.hcl
d62d9c3 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@yussufsh
revamp install steps to start nodes in sequence
d16b767 
Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@yussufsh
change deprecated key attribute
5204a63 
Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/non-mergeable size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2023
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @aishwaryabk @pravin-dsilva

Prajyot-Parab
Prajyot-Parab previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@sajauddin
Copy link
Collaborator

".terraform.lock.hcl" Is this file required?

@yussufsh
Copy link
Contributor Author

".terraform.lock.hcl" Is this file required?

As per Terraform best practice we should include and update in case of new changes. Link

You should include this file in your version control repository so that you can discuss potential changes to your external dependencies via code review, just as you would discuss potential changes to your configuration itself.

@yussufsh yussufsh mentioned this pull request Jan 30, 2023
Closed
sajauddin
sajauddin reviewed Jan 30, 2023
View reviewed changes
modules/4_nodes/nodes.tf Outdated Show resolved Hide resolved
@yussufsh
remove stale code comments
6a8fbc2 
Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@sajauddin
Copy link
Collaborator

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
Prajyot-Parab
Prajyot-Parab approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sajauddin
Copy link
Collaborator

/approve

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, sajauddin, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit bbe01f3 into ocp-power-automation:master Jan 31, 2023
@yussufsh yussufsh deleted the master branch February 1, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@sajauddin sajauddin sajauddin approved these changes

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

@aishwaryabk aishwaryabk Awaiting requested review from aishwaryabk

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

Assignees

@sajauddin sajauddin

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @sajauddin @ppc64le-cloud-bot @Prajyot-Parab