Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multipathd by default across cluster nodes #472

Merged
merged 1 commit into from
May 2, 2023

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Apr 20, 2023

If rd.multipath=* kernel option is provided we will use rhcos_pre_kernel_options value as it is.
If rd option is not provided, we will enable multipath by default by adding two options:

rd.multipath=default
root=/dev/disk/by-label/dm-mpath-root

Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/non-mergeable size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @pravin-dsilva
Please help with the review.

Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit c377386 into ocp-power-automation:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants