Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated rhcos image file name markdown generator #473

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

yussufsh
Copy link
Contributor

No description provided.

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/non-mergeable size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2023
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab

Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh
Copy link
Contributor Author

/meow
@Rajalakshmi-Girish could you please check why this is not merging?

@ppc64le-cloud-bot
Copy link
Contributor

@yussufsh: cat image

In response to this:

/meow
@Rajalakshmi-Girish could you please check why this is not merging?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rajalakshmi-Girish
Copy link

Rajalakshmi-Girish commented Jun 22, 2023

I see below message in tide log:

{"client":"github","component":"tide","controller":"sync","duration":"6.531948133s","file":"k8s.io/test-infra/prow/github/client.go:921","func":"k8s.io/test-infra/prow/github.(*client).log.func2","level":"debug","msg":"Merge(ocp-power-automation, ocp4-upi-powervs, 473, {  0a12d9a5f68156a144ab9bc9fdfc6d79ea053c66 merge}) finished","severity":"debug","time":"2023-06-22T09:25:16Z"}
{"base-sha":"c37738670417fc7d4570250e640912413a638ea9","branch":"main","component":"tide","controller":"sync","error":"status code 404 not one of [200 405 409], body: {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/reference/pulls#merge-a-pull-request\"}","file":"k8s.io/test-infra/prow/tide/github.go:275","func":"k8s.io/test-infra/prow/tide.(*GitHubProvider).mergePRs","level":"debug","merge-targets":[473],"msg":"Merge failed.","org":"ocp-power-automation","pr":473,"repo":"ocp4-upi-powervs","severity":"debug","sha":"0a12d9a5f68156a144ab9bc9fdfc6d79ea053c66","time":"2023-06-22T09:25:16Z"}
{"action":"MERGE","base-sha":"c37738670417fc7d4570250e640912413a638ea9","branch":"main","component":"tide","controller":"sync","file":"k8s.io/test-infra/prow/tide/tide.go:1676","func":"k8s.io/test-infra/prow/tide.(*syncController).syncSubpool","level":"info","msg":"Subpool synced.","org":"ocp-power-automation","repo":"ocp4-upi-powervs","severity":"info","targets":[473],"time":"2023-06-22T09:25:16Z"}

No clue why 404 for the merge request.

@Rajalakshmi-Girish
Copy link

@yussufsh This is not merging as we have change to .github/workflow.
Similar to ppc64le-cloud/pvsadm#370

Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@ppc64le-cloud-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@yussufsh
Copy link
Contributor Author

@yussufsh This is not merging as we have change to .github/workflow. Similar to ppc64le-cloud/pvsadm#370

Thanks @Rajalakshmi-Girish for checking this, I will merge manually.
So are we going to add the workflow permission to the token used by prow or I will have to manually merge workflow changes in the future as well?

@yussufsh yussufsh merged commit a66cb99 into ocp-power-automation:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants