Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for RHCOS image file names #495

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update for RHCOS image file names #495

merged 1 commit into from
Nov 6, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 5, 2023

This pull request updates the rhcos-table.md file

@yussufsh
Update rhcos-table.md
6e8e06e 
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added bot documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. labels Nov 5, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2023
@ppc64le-cloud-bot
Copy link
Contributor

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yussufsh
yussufsh approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: github-actions[bot], yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2023
@yussufsh
Copy link
Contributor

yussufsh commented Nov 5, 2023

@Rajalakshmi-Girish @mkumatag the non-mergeable label is not getting removed once approved. Have noticed this before as well. Could you please help check?

@Rajalakshmi-Girish
Copy link

@Rajalakshmi-Girish @mkumatag the non-mergeable label is not getting removed once approved. Have noticed this before as well. Could you please help check?

Though @yussufsh seems to be the author for the commit, the PR author is shown as @github-actions[bot]. Is that expected?

While I observed the logs in prow components, I didn't see any clue on why a non-mergeable label was added.

Could it be because @github-actions[bot] is not a member of this org as comment here asks for?

@yussufsh
Copy link
Contributor

yussufsh commented Nov 6, 2023 •
edited
Loading

Could it be because @github-actions[bot] is not a member of this org as comment here asks for?

That should not be an issue as this was merged before #486
Let me try adding /ok-to-test

@yussufsh
Copy link
Contributor

yussufsh commented Nov 6, 2023

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2023
@Rajalakshmi-Girish
Copy link

@yussufsh maybe you need /lgtm again like in #486 (comment)

@mkumatag
Copy link
Member

mkumatag commented Nov 6, 2023

This is the reason
image

@yussufsh
Copy link
Contributor

yussufsh commented Nov 6, 2023

This is the reason image

Where did you see it? Thanks!

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 27056b2 into main Nov 6, 2023
1 check passed
@mkumatag
Copy link
Member

mkumatag commented Nov 6, 2023

This is the reason image

Where did you see it? Thanks!

I see this next to the merge button in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@aishwaryabk aishwaryabk Awaiting requested review from aishwaryabk

@cs-zhang cs-zhang Awaiting requested review from cs-zhang

Assignees

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bot documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppc64le-cloud-bot @yussufsh @Rajalakshmi-Girish @mkumatag