Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Classic DNS with CIS #497

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Replace Classic DNS with CIS #497

merged 1 commit into from
Nov 20, 2023

Conversation

yussufsh
Copy link
Contributor

Fixes #496

@yussufsh
Replace Classic DNS with CIS
c94401f 
Fixes ocp-power-automation#496

Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/non-mergeable labels Nov 12, 2023
@ppc64le-cloud-bot
Copy link
Contributor

ppc64le-cloud-bot commented Nov 12, 2023 •
edited
Loading

@yussufsh: PR is not mergeable.

The PR state is: blocked

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2023
@yussufsh
Copy link
Contributor Author

@Prajyot-Parab please help with the test and review. Thanks!

@yussufsh yussufsh marked this pull request as draft November 12, 2023 07:38
@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2023
prb112
prb112 reviewed Nov 13, 2023
View reviewed changes
variables.tf Show resolved Hide resolved
@yussufsh yussufsh marked this pull request as ready for review November 18, 2023 05:21
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2023
@yussufsh
Copy link
Contributor Author

@Prajyot-Parab any update?

@Prajyot-Parab
Copy link
Collaborator

@Prajyot-Parab any update?

I tried multiple times few days back, was not able to get a fully successful run, will try again

@yussufsh
Copy link
Contributor Author

@Prajyot-Parab any update?

I tried multiple times few days back, was not able to get a fully successful run, will try again

Please add the details at #496. I will take a look.
Thanks.

@yussufsh yussufsh mentioned this pull request Nov 19, 2023
Closed
Prajyot-Parab
Prajyot-Parab approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh yussufsh merged commit 70d6e4c into ocp-power-automation:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prb112 prb112 prb112 left review comments

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@aishwaryabk aishwaryabk Awaiting requested review from aishwaryabk

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

Assignees

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBM Cloud Classic DNS service is deprecated use CIS instead
4 participants
@yussufsh @ppc64le-cloud-bot @Prajyot-Parab @prb112