Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding DNS entries for CIS service based cluster domain #498

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Support adding DNS entries for CIS service based cluster domain #498

merged 1 commit into from
Nov 21, 2023

Conversation

Prajyot-Parab
Copy link
Collaborator

  • Support adding DNS entries for CIS service based cluster domain

@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2023
@Prajyot-Parab
Copy link
Collaborator Author

/cc @yussufsh
This is critical for the MAC P2 CI

yussufsh
yussufsh requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prajyot-Parab Please rebase to take CIS changes.

ocp.tf Outdated Show resolved Hide resolved
ocp.tf Outdated Show resolved Hide resolved
modules/6_post_install/cis.tf Outdated Show resolved Hide resolved
modules/6_post_install/cis.tf Outdated Show resolved Hide resolved
modules/6_post_install/cis.tf Outdated Show resolved Hide resolved
modules/6_post_install/cis.tf Outdated Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab force-pushed the cis_test branch 4 times, most recently from a2ea265 to 896576c Compare November 20, 2023 08:38
yussufsh
yussufsh requested changes Nov 20, 2023
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
modules/8_custom/cis.tf Outdated Show resolved Hide resolved
yussufsh
yussufsh reviewed Nov 20, 2023
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
@Prajyot-Parab
Support adding dns entries for CIS service based cluster domain
febfb96 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
yussufsh
yussufsh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/non-mergeable labels Nov 21, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 226d605 into ocp-power-automation:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prajyot-Parab @ppc64le-cloud-bot @yussufsh