Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce resource_group constraints on VPC resources #499 #500

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Nov 21, 2023

This code is marked work in progress

@Prajyot-Parab this is the fix for:

╷
│ Error: remote-exec provisioner error
│
│   with module.install.null_resource.bootstrap_complete,
│   on modules/5_install/install.tf line 463, in resource "null_resource" "bootstrap_complete":
│  463:   provisioner "remote-exec" {
│
│ error executing "/tmp/terraform_1140640526.sh": Process exited with status 2
Error: [ERROR] Error while creating Security Group user does not have permission to use default resource group
│ {
│     "StatusCode": 403,
...
"Result": {
│         "errors": [
│             {
│                 "code": "not_authorized",
│                 "message": "user does not have permission to use default resource group"
│             }
│         ],

cc: @Chandan-Abhyankar

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2023
@prb112 prb112 changed the title [WIP] enforce resource_group constraints on VPC resources #499 enforce resource_group constraints on VPC resources #499 Nov 23, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023
@prb112
Copy link
Contributor Author

prb112 commented Nov 23, 2023

@Chandan-Abhyankar confirmed the code now works.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prb112, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/non-mergeable labels Nov 23, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 549a934 into ocp-power-automation:main Nov 23, 2023
4 of 5 checks passed
@prb112
Copy link
Contributor Author

prb112 commented Nov 23, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vpc cloud resources do not consider resource_group restrictions
3 participants