Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use bastion resource instead of data source for external IP" #55

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Sep 2, 2020

Reverts #54

Reverting this so that it can be linked to correct issue

@ltccci
Copy link
Contributor

ltccci commented Sep 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2020
@bpradipt bpradipt requested a review from yussufsh September 2, 2020 15:31
@yussufsh
Copy link
Contributor

yussufsh commented Sep 2, 2020

/ltgm

@yussufsh yussufsh merged commit de9d70d into master Sep 2, 2020
@yussufsh yussufsh deleted the revert-54-change branch September 2, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants