Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions on release branches #58

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Add instructions on release branches #58

merged 1 commit into from
Sep 3, 2020

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Sep 3, 2020

Fixes #57

Signed-off-by: Yussuf Shaikh yussuf@us.ibm.com

@ltccci ltccci added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2020
@yussufsh
Add instructions on release branches
7650b58 
Fixes #57

Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@ltccci
Copy link
Contributor

ltccci commented Sep 3, 2020

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7650b58 Add instructions on release branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yussufsh
Copy link
Contributor Author

yussufsh commented Sep 3, 2020

/cc @bpradipt

@ltccci ltccci requested a review from bpradipt September 3, 2020 09:42
@ltccci
Copy link
Contributor

ltccci commented Sep 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpradipt
Copy link
Contributor

bpradipt commented Sep 3, 2020

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@bpradipt bpradipt merged commit edca46b into ocp-power-automation:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instructions on release branches
3 participants
@yussufsh @ltccci @bpradipt