Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using Terraform 0.13 #59

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Start using Terraform 0.13 #59

merged 1 commit into from
Sep 3, 2020

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Sep 3, 2020 •
edited
Loading

Fixes #40

Signed-off-by: Yussuf Shaikh yussuf@us.ibm.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2020
@yussufsh
Copy link
Contributor Author

yussufsh commented Sep 3, 2020

/cc @bpradipt

@ltccci ltccci requested a review from bpradipt September 3, 2020 14:26
@yussufsh yussufsh force-pushed the 46 branch 3 times, most recently from 64bc5ea to fc5fc3b Compare September 3, 2020 16:07
@yussufsh
Start using Terraform 0.13
bc495e8 
Fixes #40

Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@ltccci
Copy link
Contributor

ltccci commented Sep 3, 2020

@yussufsh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ocp4-upi-powervs-terraform-validate bc495e8 link /test pull-ocp4-upi-powervs-terraform-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bpradipt
bpradipt approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @yussufsh

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpradipt
Copy link
Contributor

bpradipt commented Sep 3, 2020

@yussufsh Terraform validate failed ?

@yussufsh
Copy link
Contributor Author

yussufsh commented Sep 3, 2020

Yes it works for 0.12 version.. so till we fix the validation script for ignition provider plugin.. we need to merge PRs manually.

@bpradipt bpradipt merged commit 700d5b1 into ocp-power-automation:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Terraform 0.13
3 participants
@yussufsh @ltccci @bpradipt