Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update playbook tag to fix chrony conf file overwrite issue #63

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Update playbook tag to fix chrony conf file overwrite issue #63

merged 1 commit into from
Sep 4, 2020

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Sep 3, 2020

Fixes #62

Signed-off-by: Yussuf Shaikh yussuf@us.ibm.com

@yussufsh
Update playbook tag to fix chrony conf file overwrite issue
33e13b2 
Fixes #62

Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 3, 2020

@yussufsh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ocp4-upi-powervs-terraform-validate 33e13b2 link /test pull-ocp4-upi-powervs-terraform-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Prajyot-Parab
Copy link
Collaborator

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@yussufsh
Copy link
Contributor Author

yussufsh commented Sep 4, 2020

/cc @bpradipt

@ltccci ltccci requested a review from bpradipt September 4, 2020 04:22
bpradipt
bpradipt approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @yussufsh

@ltccci ltccci assigned bpradipt and unassigned Prajyot-Parab Sep 4, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpradipt bpradipt merged commit b2a66d5 into ocp-power-automation:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update playbook tag to fix chrony conf file overwrite issue
4 participants
@yussufsh @ltccci @Prajyot-Parab @bpradipt