prevent bash expansion in password var #78
Conversation
Single quotes will keep any bash expansion from being done inside a bash string. If you have any special bash characters in your password, the rh subscription fails in your bastion node and no servives will be available for your cluster. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
ltccci
added
the
size/XS
|
I submitted this against master instead of the 4.5 branch even though it's the default branch -- assuming it'll get cherry-picked in. Or I can submit a 2nd PR to that branch if this one's good to go. |
|
/lgtm |
|
/approve |
ltccci
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, clnperez, mkumatag, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yussufsh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
Single quotes will keep any bash expansion from being done inside a string.
If you have any special bash characters in your password, the rh
subscription fails in your bastion node and no services will be
available for your cluster.
Signed-off-by: Christy Norman christy@linux.vnet.ibm.com